From: Mike Sun Date: Wed, 30 May 2012 17:51:58 +0000 (-0400) Subject: Fixing a bug where SOCIAL_AUTH_NEW_USER_REDIRECT_URL doesn't work because user.is_new... X-Git-Url: https://git.parisson.com/?a=commitdiff_plain;h=06ee9006fad80249293ce156d15d33a949eeba54;p=django-social-auth.git Fixing a bug where SOCIAL_AUTH_NEW_USER_REDIRECT_URL doesn't work because user.is_new attribute value gets changed by a login() call prior to its use. --- diff --git a/social_auth/views.py b/social_auth/views.py index 13bd330..bebcc78 100644 --- a/social_auth/views.py +++ b/social_auth/views.py @@ -103,6 +103,7 @@ def complete_process(request, backend, *args, **kwargs): if user: if getattr(user, 'is_active', True): + is_new = getattr(user, 'is_new', False) login(request, user) # user.social_user is the used UserSocialAuth instance defined # in authenticate process @@ -127,7 +128,7 @@ def complete_process(request, backend, *args, **kwargs): # account, send him to the new-users-page if defined. new_user_redirect = backend_setting(backend, 'SOCIAL_AUTH_NEW_USER_REDIRECT_URL') - if new_user_redirect and getattr(user, 'is_new', False): + if new_user_redirect and is_new: url = new_user_redirect else: url = redirect_value or \