From: notmasteryet <async.processingjs@yahoo.com>
Date: Sun, 4 Mar 2012 01:27:35 +0000 (-0600)
Subject: Chrome extension: uses encodeURIComponent; fixes download button
X-Git-Url: https://git.parisson.com/?a=commitdiff_plain;h=0c7d45bbfb232403bd9c285542c2273e5d3470d6;p=pdf.js.git

Chrome extension: uses encodeURIComponent; fixes download button
---

diff --git a/extensions/chrome/pdfHandler.html b/extensions/chrome/pdfHandler.html
index 1d213bb..fc67c58 100644
--- a/extensions/chrome/pdfHandler.html
+++ b/extensions/chrome/pdfHandler.html
@@ -1,18 +1,28 @@
 <!doctype html>
 <script>
+
+function isPdfDownloadable(details) {
+  return details.url.indexOf('pdfjs.action=download') >= 0;
+}
+
 chrome.webRequest.onBeforeRequest.addListener(
   function(details) {
+    if (isPdfDownloadable(details))
+      return;
+
     var viewerPage = 'content/web/viewer.html';
-    var url = chrome.extension.getURL(viewerPage) + '?file=' + details.url;
+    var url = chrome.extension.getURL(viewerPage) +
+      '?file=' + encodeURIComponent(details.url);
     return { redirectUrl: url };
   },
   {
     urls: [
       "http://*/*.pdf",
-      "file://*/*.pdf",
+      "file://*/*.pdf"
     ],
     types: [ "main_frame" ]
   },
   ["blocking"]);
+
 </script>
 
