From: Tom Walker <tomwalker0472@gmail.com>
Date: Sun, 27 Jul 2014 21:14:57 +0000 (+0100)
Subject: cleaning up code, improving the default template
X-Git-Url: https://git.parisson.com/?a=commitdiff_plain;h=1a3954aeba6b8cd39cf3f67d770437be7b0d40c9;p=django_quiz.git

cleaning up code, improving the default template
---

diff --git a/quiz/models.py b/quiz/models.py
index b52e33c..d6b97e5 100644
--- a/quiz/models.py
+++ b/quiz/models.py
@@ -425,6 +425,7 @@ class Sitting(models.Model):
         self.user_answers = json.dumps(current)
         self.save()
 
+    @property
     def questions_with_user_answers(self):
         output = {}
         user_answers = json.loads(self.user_answers)
diff --git a/quiz/templates/quiz/quiz_list.html b/quiz/templates/quiz/quiz_list.html
index f0e0fda..4099581 100644
--- a/quiz/templates/quiz/quiz_list.html
+++ b/quiz/templates/quiz/quiz_list.html
@@ -4,12 +4,39 @@
 {% block content %}
 <h2>List of quizzes</h2>
     {% if quiz_list %}
-        <ul>
+		<table class="table table-bordered table-striped">
+
+		  <thead>
+			<tr>
+			  <th>Title</th>
+			  <th>Category</th>
+			  <th>Exam</th>
+			  <th>Single attempt</th>
+			  <th></th>
+			</tr>
+		  </thead>
+
+		  <tbody>
+
         {% for quiz in quiz_list %}
-            <li><a href="{% url 'quiz_start_page' slug=quiz.url %}">{{ quiz.title }}</a></li>
+
+  			<tr>
+			  <td>{{ quiz.title }}</td>
+			  <td>{{ quiz.category }}</td>
+			  <td>{{ quiz.exam_paper }}</td>
+			  <td>{{ quiz.single_attempt }}</td>
+			  <td>
+				<a href="{% url 'quiz_start_page' slug=quiz.url %}">
+				  View details
+				</a>
+			</tr>
+
         {% endfor %}
-        </ul>
-    {% else %}
+		  </tbody>
+
+		</table>
+
+	{% else %}
         <p>There are no available quizzes.</p>
     {% endif %}
 {% endblock %}
diff --git a/quiz/templates/quiz/sitting_detail.html b/quiz/templates/quiz/sitting_detail.html
index 254dfb5..1812dcf 100644
--- a/quiz/templates/quiz/sitting_detail.html
+++ b/quiz/templates/quiz/sitting_detail.html
@@ -23,13 +23,13 @@ Result of {{ sitting.quiz.title }} for {{ sitting.user }}
   </thead>
 
   <tbody>
-{% for question, user_name in questions.items %}
+{% for question, user_name in sitting.questions_with_user_answers.items %}
 
 	<tr>
 	  <td>{{ question.content }}</td>
 	  <td>{{ user_name }}</td>
 	  <td>
-		{% if question.id in incorrect %}
+		{% if question.id in sitting.get_incorrect_questions %}
 		  <p>incorrect</p>
 		{% else %}
 		  <p>Correct</p>
diff --git a/quiz/tests.py b/quiz/tests.py
index 55c8d35..8800d48 100644
--- a/quiz/tests.py
+++ b/quiz/tests.py
@@ -265,7 +265,7 @@ class TestSitting(TestCase):
         self.sitting.add_user_answer(self.question1, '123')
         self.sitting.add_user_answer(self.question2, '456')
 
-        user_answers = self.sitting.questions_with_user_answers()
+        user_answers = self.sitting.questions_with_user_answers
         self.assertEqual('123', user_answers[self.question1])
         self.assertEqual('456', user_answers[self.question2])
 
diff --git a/quiz/views.py b/quiz/views.py
index f7e5895..e22b194 100644
--- a/quiz/views.py
+++ b/quiz/views.py
@@ -17,6 +17,15 @@ class QuizMarkerMixin(object):
     def dispatch(self, *args, **kwargs):
         return super(QuizMarkerMixin, self).dispatch(*args, **kwargs)
 
+class QuizFilterByTitleMixin(object):
+    def get_queryset(self):
+        queryset = super(QuizFilterByTitleMixin, self).get_queryset()
+        quiz_filter = self.request.GET.get('quiz_filter')
+        if quiz_filter:
+            queryset = queryset.filter(quiz__title__icontains=quiz_filter)
+
+        return queryset
+
 
 class QuizListView(ListView):
     model = Quiz
@@ -72,12 +81,9 @@ class QuizUserProgressView(TemplateView):
         return context
 
 
-class QuizMarkingList(QuizMarkerMixin, ListView):
+class QuizMarkingList(QuizMarkerMixin, QuizFilterByTitleMixin, ListView):
     model = Sitting
 
-    def dispatch(self, request, *args, **kwargs):
-        return super(QuizMarkingList, self).dispatch(request, *args, **kwargs)
-
     def get_queryset(self):
         queryset = super(QuizMarkingList, self).get_queryset()\
                                                .filter(complete=True)
@@ -86,10 +92,6 @@ class QuizMarkingList(QuizMarkerMixin, ListView):
         if user_filter:
             queryset = queryset.filter(user__username__icontains=user_filter)
 
-        quiz_filter = self.request.GET.get('quiz_filter')
-        if quiz_filter:
-            queryset = queryset.filter(quiz__title__icontains=quiz_filter)
-
         return queryset
 
 
@@ -109,12 +111,6 @@ class QuizMarkingDetail(QuizMarkerMixin, DetailView):
 
         return sitting
 
-    def get_context_data(self, **kwargs):
-        context = super(QuizMarkingDetail, self).get_context_data(**kwargs)
-        context['questions'] = context['object'].questions_with_user_answers()
-        context['incorrect'] = context['object'].get_incorrect_questions
-        return context
-
 
 class QuizTake(FormView):
     form_class = QuestionForm
@@ -123,7 +119,7 @@ class QuizTake(FormView):
     def dispatch(self, request, *args, **kwargs):
         self.quiz = get_object_or_404(Quiz, url=self.kwargs['quiz_name'])
 
-        if request.user.is_authenticated() is True:
+        if request.user.is_authenticated():
             self.sitting = user_sitting(request, self.quiz)
         else:
             self.sitting = anon_load_sitting(request, self.quiz)