From: yomguy <yomguy@parisson.com>
Date: Mon, 21 May 2012 16:00:41 +0000 (+0200)
Subject: fix format handling when adding new item
X-Git-Tag: 1.4.3-2^2~17
X-Git-Url: https://git.parisson.com/?a=commitdiff_plain;h=57fd75033d9ed22974784f4997b6117c51b1ca39;p=telemeta.git

fix format handling when adding new item
---

diff --git a/telemeta/views/base.py b/telemeta/views/base.py
index 3e00f940..90718424 100644
--- a/telemeta/views/base.py
+++ b/telemeta/views/base.py
@@ -776,15 +776,14 @@ class ItemView(object):
         if request.method == 'POST':
             item_form = MediaItemForm(data=request.POST, files=request.FILES, instance=item, prefix='item')
             format_form = FormatForm(data=request.POST, instance=format, prefix='format')
-            if item_form.is_valid():
+            if item_form.is_valid() and format_form.is_valid():
                 item_form.save()
                 item.set_revision(request.user)
+                format.item = item
+                format_form.save()
                 code = item_form.cleaned_data['code']
                 if not code:
                     code = str(item.id)
-                if format_form.is_valid():
-                    format.item = item
-                    format_form.save()
                 return HttpResponseRedirect('/archives/items/'+code)
         else:
             item_form = MediaItemForm(instance=item, prefix='item')