From: riccardo <riccardo@parisson.com>
Date: Thu, 12 May 2011 14:06:49 +0000 (+0200)
Subject: cleanup of some code in mediaitem_details
X-Git-Tag: 1.1~197
X-Git-Url: https://git.parisson.com/?a=commitdiff_plain;h=642107353b88851e45ab6fbca83bde226071717c;p=telemeta.git

cleanup of some code in mediaitem_details
---

diff --git a/telemeta/htdocs/timeside/src/player.js b/telemeta/htdocs/timeside/src/player.js
index d28290bc..b73ff291 100644
--- a/telemeta/htdocs/timeside/src/player.js
+++ b/telemeta/htdocs/timeside/src/player.js
@@ -203,12 +203,16 @@ var Player = TimesideClass.extend({
         //var jQueryObjs = this.loadUI(this.getContainer(), skeleton);
 
 
+        //image source (see below) is given a src with a temporary 1x1 pixels transparent image
+        //see http://www.nczonline.net/blog/2009/11/30/empty-image-src-can-destroy-your-site/ and
+        //http://geekswithblogs.net/bcaraway/archive/2007/08/24/114945.aspx
+        //for details
         var html = ["<div class='ts-viewer'>",
                         "<div class='ts-ruler'></div>",
                         "<div class='ts-wave'>",
                             "<div class='ts-image-canvas'></div>",
                             "<div class='ts-image-container'>",
-                               "<img class='ts-image' src='' alt='' />",
+                               "<img class='ts-image' src='/images/transparent.png' alt='' />",
                             "</div>",
                         "</div>",
                     "</div>",
@@ -433,12 +437,13 @@ var Player = TimesideClass.extend({
         this.debug("resizing");
         var height;
         var container = this.getContainer();
+        
         var wave = container.find('.ts-wave');
         var image = container.find('.ts-image');
         height = wave.height();
         this.debug("wave height:" + height);
         if (!height) {
-            this.debug('ERROR: image height is zero in player.,resize!!!!')
+            //this.debug('ERROR: image height is zero in player.,resize!!!!')
             height = image.height();
         }
         //set image, imagecontainer and canvas (container on imagecontainer for lines and pointer triangles) css
@@ -537,7 +542,7 @@ var Player = TimesideClass.extend({
         var h = select.height();
         select.hide();
         var progressBar = container.find('.ts-wait').css({'width':w+'px','height':h+'px'}).show();
-        
+
         image.load(function(){
             progressBar.hide();
             select.show();
diff --git a/telemeta/templates/telemeta_default/mediaitem_detail.html b/telemeta/templates/telemeta_default/mediaitem_detail.html
index b829d80a..f5ab4850 100644
--- a/telemeta/templates/telemeta_default/mediaitem_detail.html
+++ b/telemeta/templates/telemeta_default/mediaitem_detail.html
@@ -43,41 +43,29 @@
         {% endif %}
     };
 
-//    {% if item %}
-//    var ITEM_PUBLIC_ID = '{{item.public_id}}';
-//    {% endif %}
-
-    var scripts = ["{% url telemeta-js "wz_jsgraphics.js" %}", "{% url telemeta-timeside "src/timeside.js" %}","{% url telemeta-js "playerUtils.js" %}"];
-
-    var _sound_manager_loaded=false;
-    var _jQuery_loaded = false;
+    
+    //initializing the visualizers to be passed to the player
     var visualizers = {};
     {% for v in visualizers %}
     visualizers["{{v.name}}"] = "{% url telemeta-item-visualize item.public_id,v.id,"WIDTH","HEIGHT" %}";
     {% endfor %}
     
-    jQuery(window).ready(function(){
-        _jQuery_loaded=true;
-        if(_sound_manager_loaded){
-            alert(jQuery('.ts-wave a'));
-            loadScripts(scripts, 
-            function(){
-                loadPlayer('{% url telemeta-item-analyze-xml item.public_id %}',"{% url telemeta-item-export item.public_id,"mp3" %}",'{{item.id}}', visualizers, CURRENT_USER_NAME);
-                setupPlaylist();
-            });
-        }
-    });
+    var scripts = ["{% url telemeta-js "wz_jsgraphics.js" %}", "{% url telemeta-timeside "src/timeside.js" %}","{% url telemeta-js "playerUtils.js" %}"];
 
-    soundManager.onready(function() {
-        _sound_manager_loaded=true;
-        if(_jQuery_loaded){
-            loadScripts(scripts, 
+    jQuery(window).ready(function(){
+        //if soundmanager is ready, the callback is executed immetiately
+        //onready is executed BEFORE onload, it basically queues several onload events.
+        //It it is executed immetiately if soundmanager has already been loaded
+        soundManager.onready(function() {
+            loadScripts(scripts,
             function(){
                 loadPlayer('{% url telemeta-item-analyze-xml item.public_id %}',"{% url telemeta-item-export item.public_id,"mp3" %}", '{{item.id}}', visualizers, CURRENT_USER_NAME);
                 setupPlaylist();
             });
-        }
     });
+    });
+
+
 
 </script>
 {% endif %}
@@ -117,29 +105,8 @@
             <a href="#" class="toggle">Maximize</a>
             <div class="wazing"></div>
             <div id="player" class="ts-player">
-                <!--<div class="ts-viewer">
-                    <div class="ts-wave">
-                        <div class="ts-image-container">
-                            <a href="{% url telemeta-item-export item.public_id,"mp3" %}">
-                               <img class="ts-image" src="{% url telemeta-item-visualize item.public_id,visualizer_id,360,130 %}"
-                                 alt="" /></a>
-                        </div>
-                    </div>
-                </div>-->
             </div>
         </div>
-        <!-- <div class="item_visualization" id="item_visualization_id">
-            <form id="visualizer_id_form" method="get" action="#">
-                <img src="images/plots.png" style="vertical-align:middle" />&nbsp;Visualization :
-                <select id="visualizer_id" name="visualizer_id">
-                    {% for v in visualizers %}
-                    <option value="{% url telemeta-item-visualize item.public_id,v.id,"WIDTH","HEIGHT" %}">
-                            {{v.name}}</option>
-                    {% endfor %}
-                </select>
-                <input style="visibility: hidden;" type="submit" value="Set" />
-            </form> -->
-
         <!--
                 <form method="get" action="#">
                     <p>&nbsp;Vamp plugin analysis</p>
@@ -153,7 +120,6 @@
                 </form>
         -->
         <!-- </div> -->
-
         <div id="tabs_container">
             <!-- this div will be hidden when everything is fully loaded-->
             <span id="loading_span" href="#"><img style="vertical-align:middle" src="/images/wait.gif"/>&nbsp;
@@ -172,19 +138,6 @@
                     <td>{% trans "Value" %}</td>
                     <td>{% trans "Unit" %}</td>
                 </tr>
-                <!-- {% for analyser in analysers %}
-                 <tr class="analyzer-line">
-                     <td>
-                         {{ analyser.name }}
-                     </td>
-                     <td>
-                         {{ analyser.value }}
-                     </td>
-                     <td>
-                         {{ analyser.unit }}
-                     </td>
-                 </tr>
-                 {% endfor %}-->
             </table>
         </div>
         <!--</div>-->