From: Guillaume Pellerin <yomguy@parisson.com>
Date: Wed, 17 Mar 2021 15:43:17 +0000 (+0100)
Subject: fix previous user
X-Git-Tag: 1.4.3~10
X-Git-Url: https://git.parisson.com/?a=commitdiff_plain;h=9b0073dc8626bbf7eba0cf9bf66beb284ebecb67;p=teleforma.git

fix previous user
---

diff --git a/teleforma/views/crfpa.py b/teleforma/views/crfpa.py
index 83da3cb5..b30ce86b 100644
--- a/teleforma/views/crfpa.py
+++ b/teleforma/views/crfpa.py
@@ -426,7 +426,16 @@ class UserXLSBook(object):
         period = Period.objects.get(name=period)
         users = User.objects.filter(first_name=first_name, last_name=last_name, email=email)
 
-        if not users:
+        student = None
+        if users:
+            for user in users:
+                students = Student.objects.filter(user=user, period=period)
+                if students:
+                    print(last_name.encode('utf8') + ' : updating')
+                    student = students[0]
+                    break
+
+        if not student:
             print(last_name.encode('utf8') + ' : creating')
             username = get_unique_username(first_name, last_name)
             user = User(first_name=first_name, last_name=last_name, email=email, username=username)
@@ -479,14 +488,6 @@ class UserXLSBook(object):
 
             student.save()
 
-        else:
-            print(last_name.encode('utf8') + ' : updating')
-            for user in users:
-                try:
-                    student = Student.objects.get(user=user, period=period)
-                except:
-                    continue
-
         i = 24
         for month in months_choices:
             amount = row[i]