From: Rob Sayre <sayrer@gmail.com>
Date: Sun, 26 Jun 2011 17:58:41 +0000 (-0700)
Subject: Check for browsers in verifyOptions, so the script fails early.
X-Git-Url: https://git.parisson.com/?a=commitdiff_plain;h=9ca7cbdc7388926c9e697dbb71ac4b446acd6de7;p=pdf.js.git

Check for browsers in verifyOptions, so the script fails early.
---

diff --git a/test/test.py b/test/test.py
index 96aeb5c..b867251 100644
--- a/test/test.py
+++ b/test/test.py
@@ -37,6 +37,8 @@ class TestOptions(OptionParser):
             options.manifestFile = DEFAULT_MANIFEST_FILE
         if options.browser and options.browserManifestFile:
             print "Warning: ignoring browser argument since manifest file was also supplied"
+        if not options.browser and not options.browserManifestFile:
+            self.error("No test browsers found. Use --browserManifest or --browser args.")
         return options
         
 def prompt(question):
@@ -219,10 +221,9 @@ def setUp(options):
     if options.browserManifestFile:
         testBrowsers = makeBrowserCommands(options.browserManifestFile)
     elif options.browser:
-        testBrowsers = [BrowserCommand({"path":options.browser, "name":"firefox"})] 
-    else:
-        print "No test browsers found. Use --browserManifest or --browser args."
-              
+        testBrowsers = [BrowserCommand({"path":options.browser, "name":"firefox"})]
+    assert len(testBrowsers) > 0
+
     with open(options.manifestFile) as mf:
         manifestList = json.load(mf)