From 51b1310ff418eabebae69d546c06bf369260f9d3 Mon Sep 17 00:00:00 2001
From: yomguy <yomguy@parisson.com>
Date: Tue, 25 Sep 2012 14:06:17 +0200
Subject: [PATCH] excluded fields in forms

---
 telemeta/forms/format.py                        |  1 +
 telemeta/forms/media.py                         |  4 ++++
 telemeta/templates/telemeta/mediaitem_edit.html | 13 +++++++------
 telemeta/views/item.py                          |  2 --
 4 files changed, 12 insertions(+), 8 deletions(-)

diff --git a/telemeta/forms/format.py b/telemeta/forms/format.py
index 74623695..fa3cc1c5 100644
--- a/telemeta/forms/format.py
+++ b/telemeta/forms/format.py
@@ -6,3 +6,4 @@ from telemeta.models import *
 class FormatForm(ModelForm):
     class Meta:
         model = Format
+        exclude = ('item')
diff --git a/telemeta/forms/media.py b/telemeta/forms/media.py
index c222eaeb..2fec286e 100644
--- a/telemeta/forms/media.py
+++ b/telemeta/forms/media.py
@@ -69,6 +69,9 @@ class MediaCollectionRelatedForm(ModelForm):
 class MediaItemForm(ModelForm):
     class Meta:
         model = MediaItem
+
+        exclude = ('copied_from_item')
+
     def clean_code(self):
         return self.cleaned_data['code'] or None
 
@@ -92,3 +95,4 @@ class MediaItemPerformanceForm(ModelForm):
 class PlaylistForm(ModelForm):
     class Meta:
         model = Playlist
+
diff --git a/telemeta/templates/telemeta/mediaitem_edit.html b/telemeta/templates/telemeta/mediaitem_edit.html
index e22224aa..e4c0148d 100644
--- a/telemeta/templates/telemeta/mediaitem_edit.html
+++ b/telemeta/templates/telemeta/mediaitem_edit.html
@@ -20,11 +20,13 @@
 
     {% for field in form %}
     <tr>
-    {% if field.html_name in hidden_fields %}
-        <td>{{ field.label_tag.as_hidden }}{{ field.as_hidden }}</td>
-    {% else %}
-        <tr><td class="error">{{ field.errors }}</td></tr>
-        <td>{{ field.label_tag }}:</td>
+    <tr><td class="error">{{ field.errors }}</td></tr>
+        <td>{% if field.required %}
+                <span style="font-weight:bold">{{ field.label_tag }}:</span>
+            {% else %}
+                {{ field.label_tag }}:
+            {% endif %}
+            </td>
             {% if field.html_name == "collection" %}
             <td>&nbsp;{% trans "Title" %} : {{ item.collection.title }}<br />
                 &nbsp;{% trans "Code" %} : {{ item.collection.code }}<br />
@@ -32,7 +34,6 @@
             {% else %}
             <td>{{ field }}</td>
             {% endif %}
-    {% endif %}
     </tr>
     {% endfor %}
     {% endfor %}
diff --git a/telemeta/views/item.py b/telemeta/views/item.py
index 5fea6834..a2199140 100644
--- a/telemeta/views/item.py
+++ b/telemeta/views/item.py
@@ -206,14 +206,12 @@ class ItemView(object):
             format_form = FormatForm(instance=format, prefix='format')
 
         forms = [item_form, format_form]
-        hidden_fields = ['item-copied_from_item', 'format-item']
 
         return render(request, template,
                     {'item': item, 'export_formats': formats,
                     'visualizers': graphers, 'visualizer_id': grapher_id,
                     'audio_export_enabled': getattr(settings, 'TELEMETA_DOWNLOAD_ENABLED', True),
                     'forms': forms, 'previous' : previous, 'next' : next, 'mime_type': mime_type,
-                    'hidden_fields': hidden_fields,
                     })
 
     def related_media_item_stream(self, request, item_public_id, media_id):
-- 
2.39.5