From 8579aebb962d85abead30d8092ac7031ff4e6f32 Mon Sep 17 00:00:00 2001 From: Guillaume Pellerin Date: Thu, 12 Feb 2015 17:48:56 +0100 Subject: [PATCH] fix url after item edit --- telemeta/views/item.py | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/telemeta/views/item.py b/telemeta/views/item.py index cfa5432e..057de122 100644 --- a/telemeta/views/item.py +++ b/telemeta/views/item.py @@ -749,14 +749,12 @@ class ItemEditView(ItemViewMixin, UpdateWithInlinesView): def forms_valid(self, form, inlines): messages.info(self.request, ugettext_lazy("You have successfully updated your item.")) - obj = form.save() - obj.set_revision(self.request.user) + item = form.save() + item.set_revision(self.request.user) return super(ItemEditView, self).forms_valid(form, inlines) def get_success_url(self): - #FIXME should be in form_valid but doesn't work with extra_views - self.get_object().set_revision(self.request.user) - return reverse_lazy('telemeta-item-detail', kwargs={'public_id':self.object.code}) + return reverse_lazy('telemeta-item-detail', kwargs={'public_id':self.get_object().code}) def get_context_data(self, **kwargs): context = super(ItemEditView, self).get_context_data(**kwargs) -- 2.39.5