From f3339ccbfc24d08c61122701a269302aa67eecbd Mon Sep 17 00:00:00 2001 From: =?utf8?q?Mat=C3=ADas=20Aguirre?= Date: Mon, 19 Sep 2011 18:24:52 -0300 Subject: [PATCH] Remove ERROR_KEY/NAME_KEY --- social_auth/models.py | 1 + social_auth/views.py | 12 ------------ 2 files changed, 1 insertion(+), 12 deletions(-) diff --git a/social_auth/models.py b/social_auth/models.py index 4522a6a..6d05201 100644 --- a/social_auth/models.py +++ b/social_auth/models.py @@ -6,6 +6,7 @@ from django.conf import settings from social_auth.fields import JSONField + # If User class is overridden, it *must* provide the following fields # and methods work with django-social-auth: # diff --git a/social_auth/views.py b/social_auth/views.py index 79a55f3..4de8b8d 100644 --- a/social_auth/views.py +++ b/social_auth/views.py @@ -40,8 +40,6 @@ SOCIAL_AUTH_LAST_LOGIN = _setting('SOCIAL_AUTH_LAST_LOGIN', SESSION_EXPIRATION = _setting('SOCIAL_AUTH_SESSION_EXPIRATION', True) BACKEND_ERROR_REDIRECT = _setting('SOCIAL_AUTH_BACKEND_ERROR_URL', LOGIN_ERROR_URL) -ERROR_KEY = _setting('SOCIAL_AUTH_BACKEND_ERROR', 'socialauth_backend_error') -NAME_KEY = _setting('SOCIAL_AUTH_BACKEND_KEY', 'socialauth_backend_name') SANITIZE_REDIRECTS = _setting('SOCIAL_AUTH_SANITIZE_REDIRECTS', True) @@ -81,16 +79,6 @@ def dsa_view(redirect_name=None): else: logger.warn('Messages framework not in place, some '+ 'errors have not been shown to the user.') - # What's the use in this, having not both the messages - # framework and decent logging in place? - # Also: do we really want to share all and any errors back - # to the user, in a security-wise sensitive application? - # - # else: - # if ERROR_KEY: # store error in session - # request.session[ERROR_KEY] = msg - # if NAME_KEY: # store the backend name for convenience - # request.session[NAME_KEY] = backend_name return HttpResponseRedirect(BACKEND_ERROR_REDIRECT) return wrapper return dec -- 2.39.5